Skip to content

Issue 395 first test#402

Merged
whikernel merged 11 commits into
dfir-iris:developfrom
c8y3:issue_395_first_test
Feb 21, 2024
Merged

Issue 395 first test#402
whikernel merged 11 commits into
dfir-iris:developfrom
c8y3:issue_395_first_test

Conversation

@c8y3

@c8y3 c8y3 commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

This is a proposition to set up automatic tests for the REST API.
The tests are automatically run for every push with github actions.

Some notes:

  • in order to ensure tests isolation (modification of the database by some test should not impact the results of another test), the docker-compose is started before each test and stopped after each, the volumes are pruned
  • warning: running the tests will modify the .env at the root of the repository. It would be probably nicer to run the tests in an another directory (for instance tests/work_directory) or maybe a temporary directory. But to do that, it is necessary to copy the docker-compose and everything else needed to run in this directory. The current docker-compose makes this too complex. It would be nice to separate the build aspects from the run aspects of the docker-compose and also to try to minimize the number of dockers which are built ad-hoc...
  • the same issue is seen again in the github actions.

@whikernel
whikernel changed the base branch from master to develop February 7, 2024 20:50
@c8y3
c8y3 force-pushed the issue_395_first_test branch from 866da58 to 30979a4 Compare February 9, 2024 15:03
@whikernel
whikernel self-requested a review February 21, 2024 16:05
@whikernel whikernel self-assigned this Feb 21, 2024
@whikernel
whikernel merged commit a99c78a into dfir-iris:develop Feb 21, 2024
@c8y3
c8y3 deleted the issue_395_first_test branch February 26, 2024 14:08
@c8y3 c8y3 added enhancement New feature or request and removed quality labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants