Skip to content

First implementation of "Duplicate" button for events in timeline#91

Merged
whikernel merged 4 commits intodfir-iris:developfrom
sebastiandemmer:master
Apr 12, 2022
Merged

First implementation of "Duplicate" button for events in timeline#91
whikernel merged 4 commits intodfir-iris:developfrom
sebastiandemmer:master

Conversation

@sebastiandemmer
Copy link
Copy Markdown
Contributor

This pull request implements a "Duplicate" button in both "cogwheel" menu and "quick action" menu in the modal.
Added a /case/timeline/events/duplicate/<int:cur_id> route for that, which duplicates the selected Event based on Id and creates a new one with identical values with the exception of:

  • event_added
  • user_id
  • event_title: which is prefixed with "[DUPLICATED] - "
    No DB model changes needed besides helper functions.

Let me know if I can help implement this better and please have a look at the module hooks, I am not sure they are correct. I took them from the "Add event" function because they are mostly identical.

@whikernel whikernel self-requested a review April 11, 2022 20:58
@whikernel whikernel self-assigned this Apr 11, 2022
@whikernel whikernel added the enhancement New feature or request label Apr 11, 2022
@whikernel whikernel added this to the v1.4.2 milestone Apr 11, 2022
Copy link
Copy Markdown
Contributor

@whikernel whikernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks ! That's super usefull 👍
For us after merge :

  • Add on_preload_event_duplicate as hook in post_init and documentation.
  • Add missing duplicate_event JS call in modal
  • Restrain scope of get_event_assets_id

@whikernel whikernel merged commit 98d988b into dfir-iris:develop Apr 12, 2022
whikernel added a commit to dfir-iris/iris-doc-src that referenced this pull request Apr 12, 2022
whikernel added a commit to dfir-iris/dfir-iris.github.io that referenced this pull request Apr 12, 2022
@whikernel whikernel mentioned this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants