Fix check for absolute path #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please merge this. It makes everything unusable on Windows... |
|
👍 I've tried to use Sculpin and it failed. After some debugging I found the same bug and then this PR. Merge it please. |
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not as advanced as used by the Symfony Filesystem component, but at last it supports more paths (like Windows paths).
Before this PR, the paths resulted in
C:\Users\wouter\Documents\sculpin\C:\Users\wouter\Documents\sculpin\composer.json, which is invalid of course.I wonder if we actually need to do this, as
->get('vendor-dir')always returns an absolute path in Composer?