New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner and shaded nodes in same graph #94

Open
lindeloev opened this Issue Nov 23, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@lindeloev

lindeloev commented Nov 23, 2017

Lee & Wagenmakers (2014) propose to add inner circles for deterministic nodes and shaded for observed nodes. However, I have to choose in daft.PGM(observed_style='shaded').

For now, my workaround is to add another "empty" scaled down node, but the spaces between the two are not equal for ellipses for which the scaling changes more in one direction than another. So it is not satisfactory.

pgm.add_node(daft.Node('det', '$node$', 0, 0, aspect=2))  # Deterministic
pgm.add_node(daft.Node('none', '', 0, 0, scale=0.85, aspect=2))  # Inner ellipse on deterministic
pgm.add_node(daft.Node('obs', '$obs$', 1, 1, observed=True))  # Shaded observed
@davidwhogg

This comment has been minimized.

Show comment
Hide comment
@davidwhogg

davidwhogg Nov 23, 2017

Collaborator

This is a good idea; we should have the nodes "inherit" observed_style but permit it to be over-ridden.

Our development is slow these days, but if you want to hack, it is an open-source project, and we accept pull requests!

Collaborator

davidwhogg commented Nov 23, 2017

This is a good idea; we should have the nodes "inherit" observed_style but permit it to be over-ridden.

Our development is slow these days, but if you want to hack, it is an open-source project, and we accept pull requests!

@lindeloev

This comment has been minimized.

Show comment
Hide comment
@lindeloev

lindeloev Nov 23, 2017

I'd rather there was a deterministic_style in daft.PGM too and an option to set deterministic = True in daft.Node

I have too much on my plate these days, unfortunately. But now the idea is presented :-)

lindeloev commented Nov 23, 2017

I'd rather there was a deterministic_style in daft.PGM too and an option to set deterministic = True in daft.Node

I have too much on my plate these days, unfortunately. But now the idea is presented :-)

@davidwhogg

This comment has been minimized.

Show comment
Hide comment
@davidwhogg

davidwhogg Nov 24, 2017

Collaborator

There is a “fixed” style , so this already exists. We just need to give it more options.

Collaborator

davidwhogg commented Nov 24, 2017

There is a “fixed” style , so this already exists. We just need to give it more options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment