Skip to content

Conversation

@CodeProKid
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 6, 2018

Codecov Report

Merging #57 into master will decrease coverage by 0.83%.
The diff coverage is 10%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
- Coverage      62.9%   62.06%   -0.84%     
- Complexity      144      147       +3     
============================================
  Files             7        7              
  Lines           399      406       +7     
============================================
+ Hits            251      252       +1     
- Misses          148      154       +6
Impacted Files Coverage Δ Complexity Δ
src/Register.php 82.53% <10%> (-8.54%) 8 <3> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976efee...ec6ef83. Read the comment docs.

Copy link

@davidvexel davidvexel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is a little bit different than the mason PR's, but looks good to me anyways.

@davidvexel davidvexel merged commit 44369fd into dfmedia:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants