From 711c14ad4356dea5fa4be08139d507d98b8706cc Mon Sep 17 00:00:00 2001 From: CodeProKid Date: Wed, 5 Sep 2018 08:02:26 -0600 Subject: [PATCH 1/3] Excluding tasks from some VIP events --- src/Register.php | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/src/Register.php b/src/Register.php index 568728b..b0911b6 100644 --- a/src/Register.php +++ b/src/Register.php @@ -21,6 +21,9 @@ public function setup() { add_filter( 'option_jetpack_sync_settings_post_types_blacklist', [ $this, 'blacklist_post_type' ] ); add_filter( 'default_option_jetpack_sync_settings_post_types_blacklist', [ $this, 'blacklist_post_type' ] ); + // Performance improvement for VIP + add_filter( 'wpcom_async_transition_post_status_schedule_async', [ $this, 'disable_post_transition' ], 10, 2 ); + } /** @@ -138,4 +141,27 @@ public function blacklist_post_type( $post_types ) { return $post_types; } + /** + * Disables the post transition cron event for the wpqt-task post type on WordPress VIP + * + * @param bool $value Whether or not to run the event + * @param array $args The arguments normally going to the cron event + * + * @return bool + * @access public + */ + public function disable_post_transition( $value, $args ) { + + if ( empty( $args['post_id'] ) ) { + return $value; + } + + if ( 'wpqt-task' === get_post_status( absint( $args['post_id'] ) ) ) { + $value = false; + } + + return $value; + + } + } From 5907dc2c7fe7d49898a0c28642d1e95811304f23 Mon Sep 17 00:00:00 2001 From: CodeProKid Date: Wed, 5 Sep 2018 19:27:44 -0600 Subject: [PATCH 2/3] CI-5582 changing check to post type --- src/Register.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Register.php b/src/Register.php index b0911b6..fffb02b 100644 --- a/src/Register.php +++ b/src/Register.php @@ -156,7 +156,7 @@ public function disable_post_transition( $value, $args ) { return $value; } - if ( 'wpqt-task' === get_post_status( absint( $args['post_id'] ) ) ) { + if ( 'wpqt-task' === get_post_type( absint( $args['post_id'] ) ) ) { $value = false; } From ec6ef83fd1933efc1d670fd43afabb762bba6c03 Mon Sep 17 00:00:00 2001 From: CodeProKid Date: Wed, 5 Sep 2018 19:35:20 -0600 Subject: [PATCH 3/3] CI-5582 adjusting code to use a cleaner pattern --- src/Register.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Register.php b/src/Register.php index fffb02b..04e8fe4 100644 --- a/src/Register.php +++ b/src/Register.php @@ -133,11 +133,12 @@ public function register_post_type() { * @access public */ public function blacklist_post_type( $post_types ) { - if ( is_array( $post_types ) ) { - $post_types[] = 'wpqt-task'; - } else { - $post_types = [ 'wpqt-task' ]; + if ( ! is_array( $post_types ) ) { + $post_types = []; } + + $post_types[] = 'wpqt-task'; + return $post_types; }