Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for pipenv install error; fixes #80 #81

Merged
merged 1 commit into from Nov 26, 2018
Merged

workaround for pipenv install error; fixes #80 #81

merged 1 commit into from Nov 26, 2018

Conversation

bast
Copy link
Member

@bast bast commented Nov 25, 2018

@codecov-io
Copy link

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   44.37%   44.37%           
=======================================
  Files          78       78           
  Lines        1839     1839           
=======================================
  Hits          816      816           
  Misses       1023     1023

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6acce...7e0bfd6. Read the comment docs.

@bast bast mentioned this pull request Nov 25, 2018
4 tasks
@robertodr
Copy link
Contributor

Thanks for the fix! Would you mind trying this approach: https://github.com/dev-cafe/cmake-cookbook/blob/master/.travis.yml#L105-L115 We invalidate PYENV_ROOT and then fix the version of Python to its absolute location on the Travis worker. It could get hairy with Python 2 support though. OT question: should we deprecate Python 2? I am fine with dropping it completely as of right now, for the record.

@chjacob-tubs
Copy link
Contributor

Unfortunately, I still rely on Python 2 support in XcFun for PyADF. This is on the ToDo list, but requires some significant work.

@bast
Copy link
Member Author

bast commented Nov 26, 2018

As to PYENV_ROOT: I would recommend to do this in a separate PR. My todo list is not pretty and I cannot dedicate more time to this today.

@robertodr robertodr merged commit 025d2e8 into dftlibs:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants