Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for influxdb 1.0.0 #47

Merged
merged 1 commit into from Sep 19, 2016
Merged

Add support for influxdb 1.0.0 #47

merged 1 commit into from Sep 19, 2016

Conversation

@dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented Sep 8, 2016

Contains all required configuration changes. One breaking change inside which is explicitly mentioned in the README.md (might need some adoption, I'm not sure about your release process :)).

This patch has been properly tested with the icinga2x-influxdb Vagrant box over here: https://github.com/Icinga/icinga-vagrant

ref #46

@dnsmichi dnsmichi mentioned this pull request Sep 8, 2016
Copy link
Owner

@dgolja dgolja left a comment

I use semantric versionin so this will be version 4.0.0

@dgolja
Copy link
Owner

@dgolja dgolja commented Sep 19, 2016

thank you again for the PR !! Nice job

@dgolja
dgolja approved these changes Sep 19, 2016
@dgolja
dgolja approved these changes Sep 19, 2016
@dgolja dgolja merged commit f6c3fb6 into dgolja:master Sep 19, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@dnsmichi
Copy link
Contributor Author

@dnsmichi dnsmichi commented Sep 19, 2016

Thank for the great module making my life more easy :) That's the least I can help out :) When I get more time I'd look into managing databases as well, currently solved via shell script after provisioning in our vagrant box.

@dhoppe
Copy link
Contributor

@dhoppe dhoppe commented Sep 20, 2016

Please publish a new release to get the support of InfluxDB 1.0.0 to the Forge.

@dgolja
Copy link
Owner

@dgolja dgolja commented Sep 20, 2016

I will do it hopefully today, if time permitted. I need to do more testing to make sure I don't release a broken version :(

@dhoppe
Copy link
Contributor

@dhoppe dhoppe commented Sep 20, 2016

@n1tr0g Let me help you. I created several pull requests regarding Puppet lint, Rubocop and Travis CI testing. #49 #50 #51

@dnsmichi dnsmichi mentioned this pull request Nov 27, 2017
14 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants