Run shellSchek

[MichelDiz]

Passing shell check lint.

---

This change is 

[darkn3rd]

I am curious about the quoting style, as I usually only see this if trying to capture a newline. Dropped some questions. Nothing blocking though.

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @MichelDiz)

---

getdgraph.sh, line 28 at r1 (raw file):

Quoted 4 lines of code…

acceptLower=`echo "$ACCEPT_LICENSE" | dd  conv=lcase 2> /dev/null`
systemdLower=`echo "$INSTALL_IN_SYSTEMD" | dd  conv=lcase 2> /dev/null`
ACCEPT_LICENSE=${acceptLower:-n}
INSTALL_IN_SYSTEMD=${systemdLower:-n}

Why is it necessary to subshell to lower or upper case?

ACCEPT_LICENSE=${ACCEPT_LICENSE,,:-n}
INSTALL_IN_SYSTEMD=${INSTALL_IN_SYSTEMD,,:-n}

---

getdgraph.sh, line 156 at r1 (raw file):

checksum_link=$( echo https://github.com/dgraph-io/dgraph/releases/download/"$tag"/"$checksum_file")

Not really understanding why you do this in a sub-shell. Did tag or checksum_file have new lines or tabs in the file names?

why not:

checksum_link=echo https://github.com/dgraph-io/dgraph/releases/download/$tag/$checksum_file"

---

getdgraph.sh, line 200 at r1 (raw file):

tar -C "$temp_dir" -xzf /tmp/"$tar_file"

Did these locations have spaces in them?

---

getdgraph.sh, line 220 at r1 (raw file):

		$sudo_cmd mv "$temp_dir"/* /usr/local/bin/.
		rm "/tmp/""$tar_file";
		rm -rf "$temp_dir"

I understand you need the glob outside fo the quote, but why quote-barrier $temp_dir, would this be locations with spaces in the directory name?

[MichelDiz]

If you paste the script on https://www.shellcheck.net/ you'll see all recommendations. I haven't followed all of them.

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @darkn3rd)

---

getdgraph.sh, line 28 at r1 (raw file):

Previously, darkn3rd (Joaquin Menchaca) wrote…

acceptLower=`echo "$ACCEPT_LICENSE" | dd  conv=lcase 2> /dev/null`
systemdLower=`echo "$INSTALL_IN_SYSTEMD" | dd  conv=lcase 2> /dev/null`
ACCEPT_LICENSE=${acceptLower:-n}
INSTALL_IN_SYSTEMD=${systemdLower:-n}

Why is it necessary to subshell to lower or upper case?

ACCEPT_LICENSE=${ACCEPT_LICENSE,,:-n}
INSTALL_IN_SYSTEMD=${INSTALL_IN_SYSTEMD,,:-n}

I don't remember exactly why, but I just followed a recommendation. But not sure what you mean, is there some issue? BTW this isn't part of this PR and it was long ago.

---

getdgraph.sh, line 156 at r1 (raw file):

Previously, darkn3rd (Joaquin Menchaca) wrote…

checksum_link=$( echo https://github.com/dgraph-io/dgraph/releases/download/"$tag"/"$checksum_file")

Not really understanding why you do this in a sub-shell. Did tag or checksum_file have new lines or tabs in the file names?

why not:

checksum_link=echo https://github.com/dgraph-io/dgraph/releases/download/$tag/$checksum_file"

That was a recommendation from https://www.shellcheck.net/

---

getdgraph.sh, line 200 at r1 (raw file):

Previously, darkn3rd (Joaquin Menchaca) wrote…

tar -C "$temp_dir" -xzf /tmp/"$tar_file"

Did these locations have spaces in them?

Spaces? which spaces?

---

getdgraph.sh, line 220 at r1 (raw file):

Previously, darkn3rd (Joaquin Menchaca) wrote…

		$sudo_cmd mv "$temp_dir"/* /usr/local/bin/.
		rm "/tmp/""$tar_file";
		rm -rf "$temp_dir"

I understand you need the glob outside fo the quote, but why quote-barrier $temp_dir, would this be locations with spaces in the directory name?

Again, that's from https://www.shellcheck.net/