add error due to unsupported platform #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will check if it is running on macOS. If the user wanna install some old version. He can still install it if he use the flag -v plus the version he wants.
danielmai
suggested changes
Apr 14, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MichelDiz)
getdgraph.sh, line 350 at r1 (raw file):
if [[ -z $REGX && "$platform" == "darwin" ]]; then print_error "Sorry, we don't have new binaries for this platform anymore. Please build from source."
Can you mention the -v / --version option here like you did the PR description?
MichelDiz
commented
Apr 15, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai)
getdgraph.sh, line 350 at r1 (raw file):
Previously, danielmai (Daniel Mai) wrote…
Can you mention the -v / --version option here like you did the PR description?
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check if it is running on macOS. If the user wanna install some old version. He can still install it if he use the flag -v plus the version he wants.
This change is