Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't modify tags! #904
The first one was the removal of the original
Please, stop modifying tags. All of this could have been avoided by just pushing
What is even worst, nobody should be using
Characteristic builds errors:
First of all apologies for the inconvenience. We have not published any version of Badger for a while and getting the repo back in shape for v2 is proving harder than we expected.
I personally deleted this tag because there had never been any v2.0.0-rc.1 at all, so the tag itself didn't really make sense from a semantic versioning point of view. We quickly realized with #886 that some (ipfs-go) depended on this mysterious tag so we put it back on but clearly on the wrong commit.
I'm curious about how you ended up depending on this tag? Was it an automated choice made by your dependency management tool? Was there any other reasoning behind?
Again, I am very sorry for the inconvenience. We promise this won't happen again.
Hi, It was an automatic choice made by Go when doing:
I think it was pointing to https://github.com/Kubuxu/badger/releases/tag/v2.0-rc1
Oh, that's bad indeed because that's actually really far from being the latest tag.
I will be tagging a
I'm wondering whether it's better to modify the tag once more and just set it back to what it was pointing to, or if that could cause even more issues for those depending on that tag.
You could also use
OK, I've decided to leave this tag as is.
If you need to go back to what the code looked like before any backwards incompatible change was made I recommend using
We will directly jump to
Again, sorry for the inconvenience, it won't happen again.
Sorry to jump in late here after this is already closed, but our team is also running into this. As far as I can tell, leaving the tag pinned as is really doesn't help anyone. Those of use who are using this renegade tag (largely the ipfs community) have chains of projects depending on that tag at the original commit. Our team did start the process of changing to
That being said, I understand that pointing to the old tag breaks semver, but that was the state of the repo earlier this week. As soon as
Now, I'm not sure what effects changing the tag back will have on
And I second what @Kubuxu said, badger itself is truly awesome
We will not skip v2.0.0, since it would just make it more confusing for everyone in the future.
If the consensus is to point
Let's not mangle the tags anymore, what is done is done. I think it will be just worst if we keep poking at it.
GOPROXY is a workaround we can use for the moment.
referenced this issue
Jun 27, 2019
I dont think this actually fixed anything, I'm getting an error that I haven't seen before:
whoever was responsible for this decision, really needs to have a stern talking too. The amount of man hours being collectively burnt by everyone effected by this, is probably worth tens of thousands of dollars. This is a royal screwup
I managed to fix this with some janky replace directives
I am the person responsible for the changes done and I apologized profusely.
Unfortunately, Go Modules surprisingly provided a tag that we had never released officially (and of which I wasn't even aware) as the
In order to fix your code, depending on v1.6.0-rc1 should be the easiest way. Next week we will release v1.6.0 if all of our tests on the release candidate are successful.
Again, sorry for the inconvenience - I sincerely am doing my best to avoid impacting our community of users while also taking the repository back to a more maintainable situation.
PS: please reach directly to me if there's any way in which I can help you debug the issues you're facing.
I haven't fully followed the history here, so big, big apologies in advance if I create any confusion.
Some quick observations:
Finally, sorry if any of this is off base, and I am definitely not sure of all of the history here, but the TLDR is it seems there might still be a problem that happens if you get master for