Rename WithCompressionType to WithCompression. #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the builder method WithCompressionType to WithCompression to be consistent with the option struct field named Compression. Update the godoc for WithCompression with the default compression algorithm used.
danielmai
requested review from
ashish-goswami,
jarifibrahim,
manishrjain and
a team
as code owners
campoy
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
joshua-goldstein
deleted the
danielmai/badger-compression-builder-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the builder method WithCompressionType to WithCompression to be
consistent with the option struct field named Compression.
Update the godoc for WithCompression with the default compression algorithm
used when Cgo is enabled (zstd) and when Cgo is disabled (snappy).
This change is