Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump github.com/google/flatbuffers to v1.12.1 #1746

Merged
merged 1 commit into from Sep 22, 2021
Merged

deps: Bump github.com/google/flatbuffers to v1.12.1 #1746

merged 1 commit into from Sep 22, 2021

Conversation

jalseth
Copy link
Contributor

@jalseth jalseth commented Sep 17, 2021

The v1.12.0 version of the flatbuffers package has an issue where the
hash of the package will differ depending on if you fetch the source
using the default, public Go Modules proxy or if you fetch the source
directly, which can cause build issues [1][2]. The flatbuffers maintainers
released v1.12.1 to fix this issue [3].

[1] https://github.com/open-policy-agent/conftest/runs/3576130950?check_suite_focus=true
[2] open-policy-agent/conftest#613
[3] google/flatbuffers#6466

Signed-off-by: James Alseth james@jalseth.me


This change is Reviewable

The v1.12.0 version of the flatbuffers package has an issue where the
hash of the package will differ depending on if you fetch the source
using the default, public Go Modules proxy or if you fetch the source
directly, which can cause build issues [1][2]. The flatbuffers maintainers
released v1.12.1 to fix this issue [3].

[1] https://github.com/open-policy-agent/conftest/runs/3576130950?check_suite_focus=true
[2] open-policy-agent/conftest#613
[3] google/flatbuffers#6466

Signed-off-by: James Alseth <james@jalseth.me>
@CLAassistant
Copy link

CLAassistant commented Sep 17, 2021

CLA assistant check
All committers have signed the CLA.

@jalseth
Copy link
Contributor Author

jalseth commented Sep 18, 2021

The CI issue appears to be unrelated to this change, so it shouldn't be blocking for this PR.

Copy link
Contributor

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. 🎉

@NamanJain8 NamanJain8 merged commit a6bf4fd into dgraph-io:master Sep 22, 2021
3 of 4 checks passed
@jalseth jalseth deleted the bump-flatbuffers branch September 23, 2021 21:47
@jalseth
Copy link
Contributor Author

jalseth commented Sep 23, 2021

@NamanJain8 Is it possible to create a patch release that includes this? We'd like to bump our badger dependency rather than relying on a replace directive for the flatbufferes package in our go.mod file.

@NamanJain8
Copy link
Contributor

Hi @jalseth, I will try to do the patch release in a few days.

NamanJain8 pushed a commit that referenced this pull request Oct 5, 2021
The v1.12.0 version of the flatbuffers package has an issue where the
hash of the package will differ depending on if you fetch the source
using the default, public Go Modules proxy or if you fetch the source
directly, which can cause build issues [1][2]. The flatbuffers maintainers
released v1.12.1 to fix this issue [3].

[1] https://github.com/open-policy-agent/conftest/runs/3576130950?check_suite_focus=true
[2] open-policy-agent/conftest#613
[3] google/flatbuffers#6466

Signed-off-by: James Alseth <james@jalseth.me>
(cherry picked from commit a6bf4fd)
@NamanJain8
Copy link
Contributor

NamanJain8 commented Oct 7, 2021

Hey @jalseth, we have released badger v3.2103.2 that contains this change.
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants