Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compact): close vlog after the compaction at L0 has completed #1752

Merged
merged 1 commit into from Sep 28, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Sep 28, 2021

Vlog needs to stay open while the compaction is being run. With the CompactL0OnClose option, it becomes necessary to close the vlog after all the compactions have been completed.

Resolves https://discuss.dgraph.io/t/badger-v3-updatediscardstats-unexpected-fault-address/15674


This change is Reviewable

@NamanJain8 NamanJain8 merged commit cba20b9 into master Sep 28, 2021
3 of 5 checks passed
@NamanJain8 NamanJain8 deleted the naman/fix-compact-l0 branch September 28, 2021 17:27
NamanJain8 added a commit that referenced this pull request Oct 5, 2021
)

Vlog needs to stay open while the compaction is being run. With the CompactL0OnClose option, it becomes necessary to close the vlog after all the compactions have been completed.

(cherry picked from commit cba20b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants