Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove refs to deprecated io/ioutil #1976

Merged
merged 3 commits into from
Jul 6, 2023
Merged

chore: remove refs to deprecated io/ioutil #1976

merged 3 commits into from
Jul 6, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Jul 4, 2023

Problem

"io/ioutil" has been deprecated since Go 1.19: As of Go 1.16

Solution

remove refs to deprecated io/ioutil

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@CLAassistant
Copy link

CLAassistant commented Jul 4, 2023

CLA assistant check
All committers have signed the CLA.

@mangalaman93
Copy link
Contributor

Hi @testwill, Thanks for the PR. Will it make sense to create a function to do this instead of doing this again and again?

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
badger/cmd/info.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion, this way it looks cleaner.

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@mangalaman93 mangalaman93 merged commit 220beca into dgraph-io:main Jul 6, 2023
6 checks passed
@testwill testwill deleted the ioutil branch July 6, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants