Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
test: Fix TestDropReadOnly failed on windows #661
I's not so sure for the problem on Munmap, maybe we should keep the handle like here: https://github.com/edsrzf/mmap-go/blob/master/mmap_windows.go#L69-L72
left a comment
nitpick: change the comment to
// acquireDirectoryLock returns ErrWindowsNotSupported on Windows. It can be ignored safely.
Comments should preferably be written in the present tense.