Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions to publish helm charts using GitHub assets #4

Merged
merged 6 commits into from Feb 11, 2020

Conversation

@prashant-shahi
Copy link
Member

prashant-shahi commented Jan 17, 2020

Signed-off-by: Prashant Shahi prashant@dgraph.io


This change is Reviewable

@prashant-shahi prashant-shahi requested a review from danielmai Jan 17, 2020
Signed-off-by: Prashant Shahi <coolboi567@gmail.com>
@prashant-shahi prashant-shahi requested a review from fristonio Feb 7, 2020
@fristonio fristonio changed the title Added instructions to publish help charts using GitHub assets Added instructions to publish helm charts using GitHub assets Feb 7, 2020
PUBLISH.md Outdated Show resolved Hide resolved
Signed-off-by: Prashant Shahi <coolboi567@gmail.com>
@prashant-shahi prashant-shahi requested a review from fristonio Feb 10, 2020
Copy link
Member Author

prashant-shahi left a comment

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @danielmai and @fristonio)


PUBLISH.md, line 8 at r2 (raw file):

Previously, fristonio (Deepesh Pathak) wrote…

I think this should be gh-pages branch.

Done.

Signed-off-by: Prashant Shahi <prashant@dgraph.io>
Copy link
Member Author

prashant-shahi left a comment

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai and @fristonio)

Copy link
Member

fristonio left a comment

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai and @fristonio)

Signed-off-by: Prashant Shahi <prashant@dgraph.io>
@prashant-shahi prashant-shahi merged commit 70f3c8d into master Feb 11, 2020
1 of 2 checks passed
1 of 2 checks passed
code-review/reviewable 2 files, 1 discussion left (danielmai, fristonio, prashant-shahi)
Details
license/cla Contributor License Agreement is signed.
Details
@prashant-shahi prashant-shahi deleted the prashant/publish-instructions branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.