Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove using fqdn with .cluster.local #50

Merged
merged 4 commits into from
Nov 6, 2020
Merged

Conversation

darkn3rd
Copy link
Contributor

@darkn3rd darkn3rd commented Nov 6, 2020

This removes references to the FQDN with domain name of cluster.local, for example:

  • BEFORE: myrelease-dgraph-zero-0.myrelease-dgraph-zero-headless.default.svc.cluster.local
  • AFTER: myrelease-dgraph-zero-0.myrelease-dgraph-zero-headless.default.svc

This fixes a few scenarios:

This works because the resolver should always have cluster.lcoal or equivalent alternative domain name. For example, on GKE, these search domains will be configured:

  • default.svc.cluster.local
  • svc.cluster.local
  • cluster.local
  • c.${PROJECT_ID}.internal
  • google.internal

This change is Reviewable

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment, and then :lgtm:

Reviewed 4 of 4 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @darkn3rd)


charts/dgraph/templates/alpha/statefulset.yaml, line 160 at r2 (raw file):

| awk '{gsub(/\.$/,""); print $0}'

Is this still needed once dgraph-io/dgraph#6837 merged? Can you add a comment explaining why this is needed and a TODO to remove this later?

Copy link
Contributor Author

@darkn3rd darkn3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @danielmai)


charts/dgraph/templates/alpha/statefulset.yaml, line 160 at r2 (raw file):

Previously, danielmai (Daniel Mai) wrote…
| awk '{gsub(/\.$/,""); print $0}'

Is this still needed once dgraph-io/dgraph#6837 merged? Can you add a comment explaining why this is needed and a TODO to remove this later?

done

@darkn3rd darkn3rd merged commit 5b6ef13 into master Nov 6, 2020
@darkn3rd darkn3rd deleted the joaquin/domain-change branch November 6, 2020 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants