fix: Configure no-persistence emptyDir correctly. #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helm installation fails when persistence is disabled. e.g., setting either
alpha.persistence.enabled or zero.persistence.enabled to false.
$ helm install dev dgraph/dgraph --set alpha.persistence.enabled=false,zero.persistence.enabled=false
Error: YAML parse error on dgraph/templates/alpha/statefulset.yaml: error converting YAML to JSON: yaml: line 88: did not find expected key
The cause for this error can be seen when rendering the template. The emptyDir
config gets mangled with the configMap:
- name: config-volume
configMap:
name: dev-dgraph-alpha-config
- name: datadir
emptyDir: {}
Error: YAML parse error on dgraph/templates/alpha/statefulset.yaml: error converting YAML to JSON: yaml: line 88: did not find expected key
helm.go:81: [debug] error converting YAML to JSON: yaml: line 88: did not find expected key
This change sets the emptyDir config in the volumes section for datadir.
Resolves https://discuss.dgraph.io/t/helm-chart-deployment-fails-when-persistence-is-disabled/12240
darkn3rd
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @danielmai)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm installation fails when persistence is disabled. e.g., setting either
alpha.persistence.enabled or zero.persistence.enabled to false.
The cause for this error can be seen when rendering the template. The emptyDir
config gets mangled with the configMap:
This change sets the emptyDir config in the volumes section for datadir.
Resolves https://discuss.dgraph.io/t/helm-chart-deployment-fails-when-persistence-is-disabled/12240
This change is