Skip to content

add template annotation support for sts/deploy to allow linkerd or ot… #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

darkn3rd
Copy link
Contributor

@darkn3rd darkn3rd commented Jul 10, 2021

This adds support for deploy and sts template annotations. This will allow for annotations that allow services to inject side-cars containers, such as linkerd proxy-injection.

This changes were added:

  • ratel.extraAnnotations for deploy template annotations
  • alpha.extraAnnotations and zero.extraAnnotations for sts template annotations
  • updated README for new value and missing metrics.enabled value
  • provided example linkerd.yaml

This was tested with the following values file:

alpha:
  extraAnnotations:
    config.linkerd.io/skip-inbound-ports: 7080
    config.linkerd.io/skip-outbound-ports: 7080
    linkerd.io/inject: enabled
zero:
  extraAnnotations:
    config.linkerd.io/skip-inbound-ports: 5080
    config.linkerd.io/skip-outbound-ports: 5080
    linkerd.io/inject: enabled
ratel:
  enabled: true
  extraAnnotations:
     linkerd.io/inject: enabled

This change is Reviewable

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @darkn3rd)

@danielmai
Copy link
Contributor

Thanks for the PR @darkn3rd!

@danielmai danielmai merged commit f081b8a into dgraph-io:master Jul 14, 2021
@darkn3rd darkn3rd deleted the joaquin/template-annotations branch July 19, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants