Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coding the Dgraph version and Updating Helm chart docs #8

Merged
merged 2 commits into from Mar 13, 2020

Conversation

@prashant-shahi
Copy link
Member

prashant-shahi commented Feb 28, 2020

  • Hard-coding the Dgraph version to the latest release (v1.2.1)
  • Moving top-level README file to dgraph chart folder and minor changes
  • Adding short top-level README

Signed-off-by: Prashant Shahi prashant@dgraph.io


This change is Reviewable

- Hardcoding Dgraph version to the latest release (v1.2.1)
- Moving top-level README to dgraph chart folder
- Adding short top-level README

Signed-off-by: Prashant Shahi <prashant@dgraph.io>
@prashant-shahi prashant-shahi requested review from danielmai and fristonio Feb 28, 2020
Copy link
Member

danielmai left a comment

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @danielmai, @fristonio, and @prashant-shahi)


README.md, line 36 at r1 (raw file):

To install Helm follow the instructions [here](https://helm.sh/docs/intro/install/).

### Add Repo

After this "Add Repo" section, please add a section about how to use it. You can simply link to the dgraph subdirectory for now so folks can follow along with the README file there.

Signed-off-by: Prashant Shahi <prashant@dgraph.io>
@prashant-shahi prashant-shahi requested a review from danielmai Mar 12, 2020
Copy link
Member Author

prashant-shahi left a comment

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @danielmai and @fristonio)


README.md, line 36 at r1 (raw file):

Previously, danielmai (Daniel Mai) wrote…

After this "Add Repo" section, please add a section about how to use it. You can simply link to the dgraph subdirectory for now so folks can follow along with the README file there.

Done.

Copy link
Member

danielmai left a comment

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @danielmai and @fristonio)

@prashant-shahi prashant-shahi merged commit 7e82661 into master Mar 13, 2020
1 of 2 checks passed
1 of 2 checks passed
code-review/reviewable 3 files, 1 discussion left (danielmai, fristonio)
Details
license/cla Contributor License Agreement is signed.
Details
@prashant-shahi prashant-shahi deleted the prashant/update-docs branch Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.