Skip to content
This repository was archived by the owner on Mar 29, 2025. It is now read-only.

Docs(liveloader): update for s3 buckets and cleanup #233

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

darkn3rd
Copy link
Contributor

@darkn3rd darkn3rd commented Jun 2, 2021

This refreshes S3 bucket content as well as some other clean-up

  • converted short flags to long flag, as long-form flags are self documenting, which is good for documentation
  • updated to be consistent
  • change reference to bulk loader to live loader for live loader documentation
  • vertically stacked long command line examples that were greater than 150 columns, so that readers don't have to constantly scroll horizontally
  • documented both long form s3://s3..amazonaws.com/ and short form s3:/// examples
  • added notes that short form s3 URL requires triple slash (s3:///) as this is something easily missed
  • normalize subtitles where appropriate to style guide

@darkn3rd darkn3rd requested review from bucanero and aaroncarey June 2, 2021 19:05
@darkn3rd darkn3rd requested a review from danielmai as a code owner June 2, 2021 19:05
@netlify
Copy link

netlify bot commented Jun 2, 2021

✔️ Deploy Preview for dgraph-docs-repo ready!

🔨 Explore the source changes: 3c31de3

🔍 Inspect the deploy log: https://app.netlify.com/sites/dgraph-docs-repo/deploys/60b7d66fd7730800078fd7c6

😎 Browse the preview: https://deploy-preview-233--dgraph-docs-repo.netlify.app

@aaroncarey aaroncarey merged commit ef52fde into master Jun 3, 2021
@aaroncarey aaroncarey deleted the joaquin/liveloader-s3-update branch June 3, 2021 00:44
aaroncarey pushed a commit that referenced this pull request Jun 3, 2021
aaroncarey pushed a commit that referenced this pull request Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants