Skip to content
This repository was archived by the owner on Mar 29, 2025. It is now read-only.

Docs(GraphQL): Say that spaces aren't the only delimiter for anyofterms #260

Closed
wants to merge 3 commits into from
Closed

Docs(GraphQL): Say that spaces aren't the only delimiter for anyofterms #260

wants to merge 3 commits into from

Conversation

catherineluse
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MichelDiz
Copy link
Contributor

Can you sign the CLA?

@MichelDiz MichelDiz added the help wanted Extra attention is needed label Aug 9, 2022
@catherineluse
Copy link
Contributor Author

I have signed it

@MichelDiz
Copy link
Contributor

Hey @catherineluse thank you for your contribution. But feels a bit odd your tittle.

You say "Docs(GraphQL):" but your edits are in the DQL part. I gonna approve, but pay attention next time. These tags in the title are for us to pre-filter the content by speeding up or decreasing the priority of the review.

@MichelDiz
Copy link
Contributor

@skrdgraph Help me out with this. She is PR against v21.03, Shouldn't be master? Maybe commit to this release and also to master.

@MichelDiz MichelDiz added the triage:delayed Decided to postpone the merge or review or release to take a closer look. label Oct 19, 2022
@catherineluse
Copy link
Contributor Author

The reason I marked it as GraphQL is because I was a GraphQL user, reading the docs for the auto-generated GraphQL API. I don't know anything about DQL. I made the doc update because I was getting weird, counterintuitive results when using the GraphQL API and had to go to the forums to figure out the reason why.

@catherineluse
Copy link
Contributor Author

Closing because this PR is cluttering up my GitHub UI. Too bad the next person will have to suffer through the same problem that I did.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichelDiz MichelDiz MichelDiz approved these changes

@danielmai danielmai Awaiting requested review from danielmai

Assignees
No one assigned
Labels
community help wanted Extra attention is needed triage:delayed Decided to postpone the merge or review or release to take a closer look.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catherineluse @CLAassistant @MichelDiz @selectiveduplicate