-
Notifications
You must be signed in to change notification settings - Fork 21
Add Running an Upsert #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ A review job has been created and sent to the PullRequest network.
@MichelDiz you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @MichelDiz)
README.md, line 234 at r1 (raw file):
runs a mutation and also upsert transactions.
"runs mutations and upsert transactions"
README.md, line 234 at r1 (raw file):
provides two main ways to set data: JSON and RDF N-Quad.
"provides two data formats" ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MichelDiz)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @martinmr)
README.md, line 234 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
runs a mutation and also upsert transactions."runs mutations and upsert transactions"
Done.
README.md, line 234 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
provides two main ways to set data: JSON and RDF N-Quad."provides two data formats" ...
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -229,6 +229,29 @@ Number of people named "Alice": 1 | |||
| Alice | |||
| ``` | |||
|
|
|||
| ### Running an Upsert | |||
|
|
|||
| Txn#mutate(Mutation) runs mutations and upsert transactions. It takes in a Mutation object, which provides two data formats: JSON and RDF N-Quad. You can choose whichever way is convenient. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right. @prashant-shahi please have a discussion about this with me. Something seems off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please DO NOT MERGE.
|
@MichelDiz closing this PR. More work needs to be done in this client. I didn't realize that the interface of the http client is similar to the grpc client. @prashant-shahi will work on this. |
Adding doc for Upserts.
This change is