Skip to content

Fix issue where setSlashApiKey would break if no headers was set. #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

Sydney-o9
Copy link
Contributor

@Sydney-o9 Sydney-o9 commented Nov 2, 2020

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2020

CLA assistant check
All committers have signed the CLA.

@MichelDiz
Copy link
Contributor

Hey @Sydney-o9 , there are some warnings on your PR

ERROR: 375:9   no-unused-expression        unused expression, expected an assignment or function call
ERROR: 375:47  strict-boolean-expressions  This type is not allowed in the operand for the '&&' operator because it is always truthy. It may be null/undefined, but neither 'allow-null-union' nor 'allow-undefined-union' is set. Only booleans are allowed.
ERROR: 380:9   no-unused-expression        unused expression, expected an assignment or function call
ERROR: 380:47  strict-boolean-expressions  This type is not allowed in the operand for the '&&' operator because it is always truthy. It may be null/undefined, but neither 'allow-null-union' nor 'allow-undefined-union' is set. Only booleans are allowed.

Copy link
Contributor

@gja gja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's remove if boolean short circuits on 375 and 380 and just make them if conditions. @vardhanapoorv could you take this forward?

@vardhanapoorv vardhanapoorv merged commit b79ad75 into dgraph-io:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants