Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added upsert tests #67

Merged
merged 2 commits into from Sep 5, 2019

Conversation

@prashant-shahi
Copy link
Member

commented Sep 5, 2019

  • Re-used the acctUpsert tests with doRequest
  • Added test for successful upsert

This change is Reviewable

Added upsert tests
- Re-used the acctUpsert tests with doRequest
- Added test for successful upsert

@prashant-shahi prashant-shahi requested a review from paulftw Sep 5, 2019

@pullrequest
Copy link

left a comment

A review job has been created and sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

@coveralls

This comment has been minimized.

Copy link

commented Sep 5, 2019

Coverage Status

Coverage remained the same at 93.284% when pulling 059758b on prashant/more-tests into c2edddc on master.

@pullrequest
Copy link

left a comment

👍 looking pretty good, I think there are a few places where the code can be simplified which I noted inline.


Reviewed with ❤️ by PullRequest

tests/integration/upsert.spec.ts Show resolved Hide resolved
tests/integration/upsert.spec.ts Show resolved Hide resolved
tests/integration/upsert.spec.ts Outdated Show resolved Hide resolved

@prashant-shahi prashant-shahi merged commit 291954b into master Sep 5, 2019

4 of 5 checks passed

code-review/reviewable 1 file, 3 discussions left (paulftw, prashant-shahi, pullrequest[bot])
Details
Build (dgraph-js) TeamCity build finished
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@prashant-shahi prashant-shahi deleted the prashant/more-tests branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.