feat: Add support for webhook #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gja
suggested changes
Mar 11, 2021
| type GraphQLEventFields = { | ||
| type: string, | ||
| parents: (Record<string, any>)[] | null, | ||
| args: Record<string, any>, | ||
| authHeader?: AuthHeaderField | ||
| authHeader?: AuthHeaderField, | ||
| event?: eventPayload | ||
| } | ||
|
|
There was a problem hiding this comment.
I would make this a different type. Instead of GraphQLEventFields, I'd make it GraphQLChangeEventFields
There was a problem hiding this comment.
OH, this is an input thing. Could you rethink these types in such a way that GraphQLEvent doesn't have .event please?
ghost
reviewed
Mar 11, 2021
src/evaluate-script.ts
Outdated
| @@ -81,12 +91,15 @@ export function evaluateScript(source: string) { | |||
|
|
|||
| return async function(e: GraphQLEventFields): Promise<any | undefined> { | |||
| let retPromise: ResolverResponse | undefined = undefined; | |||
| const event = { | |||
There was a problem hiding this comment.
Is there a reason why this is not const? I don’t see where it is reassigned.
There was a problem hiding this comment.
Oh my bad, fixed. thanks!
gja
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables support for webhook events coming from Dgraph. Check out this PR and the discuss post for more info.
Now using
self.addWebHookResolversone can add resolvers for webhook events.