Use env variable to set max memory limit and instance number #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max memory limit could be different based on the lambda resolver and sometimes it needs more memory so we should be able to set this via a environment variable. The same is true for number of instances that PM2 creates.
|
|
danielmai
approved these changes
Dec 29, 2021
|
Thanks for the PR, @pshaddel. And thanks for the review, @ahsanbarkati. |
|
@pshaddel Once the CLA is signed it's good to merge. |
All done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max memory limit could be different based on the lambda resolver and sometimes it needs more memory so we should be able to set this via a environment variable.
The same is true for number of instances that PM2 creates.
Discussion on Dgraph