From 96ab6d8b3939a05424a3731c4ea457baba4b6d10 Mon Sep 17 00:00:00 2001
From: Daniel Mai <daniel@dgraph.io>
Date: Mon, 20 Sep 2021 22:26:25 -0700
Subject: [PATCH] feat(metrics): add badger metrics (#8034)

These metrics have been part of Badger for a while. This PR
exports them in orometheus format at the /metrics endpoint.

 * badger_blocked_puts_total
 * badger_pending_writes_total
 * badger_compactions_current
---
 dgraph/cmd/alpha/metrics_test.go |  3 ++-
 x/metrics.go                     | 15 +++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/dgraph/cmd/alpha/metrics_test.go b/dgraph/cmd/alpha/metrics_test.go
index 6735343a73f..d06119dae58 100644
--- a/dgraph/cmd/alpha/metrics_test.go
+++ b/dgraph/cmd/alpha/metrics_test.go
@@ -184,7 +184,8 @@ func TestMetrics(t *testing.T) {
 		// Badger Metrics
 		"badger_disk_reads_total", "badger_disk_writes_total", "badger_gets_total",
 		"badger_memtable_gets_total", "badger_puts_total", "badger_read_bytes",
-		"badger_written_bytes",
+		"badger_written_bytes", "badger_blocked_puts_total",
+		"badger_compactions_current", "badger_pending_writes_total",
 		// The following metrics get exposed after 1 minute from Badger, so
 		// they're not available in time for this test
 		// "badger_lsm_size_bytes", "badger_vlog_size_bytes",
diff --git a/x/metrics.go b/x/metrics.go
index 8271274d7df..96149f8825b 100644
--- a/x/metrics.go
+++ b/x/metrics.go
@@ -496,6 +496,11 @@ func NewBadgerCollector() prometheus.Collector {
 			"Total number of puts",
 			nil, nil,
 		),
+		"badger_v3_blocked_puts_total": prometheus.NewDesc(
+			"badger_blocked_puts_total",
+			"Total number of blocked puts",
+			nil, nil,
+		),
 		"badger_v3_memtable_gets_total": prometheus.NewDesc(
 			"badger_memtable_gets_total",
 			"Total number of memtable gets",
@@ -511,6 +516,16 @@ func NewBadgerCollector() prometheus.Collector {
 			"Size of the value log in bytes",
 			[]string{"dir"}, nil,
 		),
+		"badger_v3_pending_writes_total": prometheus.NewDesc(
+			"badger_pending_writes_total",
+			"Total number of pending writes",
+			[]string{"dir"}, nil,
+		),
+		"badger_v3_compactions_current": prometheus.NewDesc(
+			"badger_compactions_current",
+			"Number of tables being actively compacted",
+			nil, nil,
+		),
 	})
 }