Please sign in to comment.
Fix deadlock in 10-node cluster convergence (#2467)
This PR fixes #2286 . - CheckQuorum was causing us multiple issues. When doing a 5-node Zero cluster bootstrap, it would cause a leader to step down when the size of the cluster is 2, then causing all the rest of the joins to be blocked indefinitely. It would also cause leader step down in a seemingly healthy cluster which is processing proposals. CheckQuorum was mandated by raft.ReadOnlyLeaseBased, which is a less safe option to do linearizable reads. Switch ReadOnlyOption back to raft.ReadOnlySafe. Moreover, we don't need to do quorum based lin reads in the Alpha servers, because of the switch to proposing and then applying transaction updates. - raft.ReadIndex is not working for some reason. So, commented out its usage in Zero (and removed it from Alpha permanently). Needs to be fixed when the following issue is resolved. etcd-io/etcd#9893 - The logic to do lin reads was replicated in both Zero and Alpha. Refactor that into one place in conn/node.go. - Retry conf change proposals if they timeout. This mechanism is similar to the one introduced for normal proposals in a previous commit 06ea4c. - Use a lock to only allow one JoinCluster call at a time. Block JoinCluster until node.AddToCluster is successful (or return the error). - Set raft library to 3.2.23. Before upgrade, we were at 3.2.6. Commit log: * Trying to understand why JoinCluster doesn't work properly. * Fucking works. Fucking works. * It all works now. * More Dgraph servers. Found a new issue where requesting read quorum doesn't respond. * Refactor wait lin read code and move it to conn/node.go * Remove lin read wait for server, because txn timestamp should be sufficient for waiting. Also, for the time being, comment out lin read wait from Zero as well.
- Loading branch information...
Showing with 450 additions and 666 deletions.
- +163 −38 conn/node.go
- +2 −2 conn/pool.go
- +17 −66 dgraph/cmd/zero/raft.go
- +8 −5 dgraph/cmd/zero/zero.go
- +77 −24 dgraph/docker-compose.yml
- +6 −6 vendor/github.com/coreos/etcd/raft/README.md
- +2 −4 vendor/github.com/coreos/etcd/raft/node.go
- +1 −6 vendor/github.com/coreos/etcd/raft/progress.go
- +63 −212 vendor/github.com/coreos/etcd/raft/raft.go
- +77 −139 vendor/github.com/coreos/etcd/raft/raftpb/raft.pb.go
- +4 −6 vendor/github.com/coreos/etcd/raft/raftpb/raft.proto
- +1 −3 vendor/github.com/coreos/etcd/raft/rawnode.go
- +1 −1 vendor/github.com/coreos/etcd/raft/read_only.go
- +5 −17 vendor/github.com/coreos/etcd/raft/status.go
- +14 −14 vendor/vendor.json
- +8 −122 worker/draft.go
- +1 −1 worker/groups.go
Oops, something went wrong.