JSON mutation, Support facets for value edge lists

[emile-tawfik]

Hi,

This issue follows this one #4081 and this PR #4267.

#4267 changes the output format, but does not reflect thoses changes for the input JSON mutation format.

This cause 2 issues:

• The JSON input and output are not permutable
• This impossibility to add facets to a value edge lists

I think the JSON mutation format should be modified accordingly to the output format.

Below are some examples of the modified JSON input : (coming from #4081 (comment))

Facets on a singular value predicate

Schema:

<name>: string .

Old-Data:

{
    "name|kind": "first",
    "name": "Francesc"
}

Data:

{
    "name|kind": "first",
    "name": "Francesc"
}

Query:

{
   q(func: has(name)) {
      name @facets
   }
}

Result:

{
  "data": {
    "q": [
      {
        "name|kind": "first",
        "name": "Francesc"
      }
    ]
  }
}

Facets on lists of value predicates

Schema:

<nickname>: [string] .

Old-Data:

Impossible to write

Data:

{
    "nickname": [
      "Cesc",
      "Francesc",
      "Tete"
    ],
    "nickname|kind": {
      "0": "friends",
      "1": "official"
    }
}

Query:

{
   q(func: has(nickname)) {
      nickname @facets
   }
}

Result:

{
  "data": {
    "q": [
      {
        "nickname": [
          "Cesc",
          "Francesc",
          "Tete"
        ],
        "nickname|kind": {
          "0": "friends",
          "1": "official"
        }
      }
    ]
  }
}

Facets on a singular object predicate

Schema:

<name>: string .
<state>: uid .

Old-Data:

{
    "name": "San Francisco",
    "state": [
        {
            "name": "California",
            "state|capital": false
        }
    ]
}

Data:

{
    "name": "San Francisco",
    "state": [
      {
        "name": "California"
      },
      "state|capital": false
    ]
}

Query:

{
   q(func: has(state)) {
      name
      state @facets {
         name
      }
   }
}

Result:

{
  "data": {
    "q": [
      {
        "name": "San Francisco",
        "state": [
          {
            "name": "California"
          },
          "state|capital": false
        ]
      }
    ]
  }
}

Facets on a list of object predicates

Schema:

<name>: string .
<speaks>: [uid] .

Old-Data:

{
    "name": "Francesc",
    "speaks": [
      {
        "name": "Spanish",
        "speaks|fluent": true
      },
      {
        "name": "Chinese"
        "speaks|fluent": false
      }
    ]
}

Data:

{
    "name": "Francesc",
    "speaks": [
      {
        "name": "Spanish"
      },
      {
        "name": "Chinese"
      }
    ],
    "speaks|fluent": {
       "0": true,
       "1": false
    }
}

Query:

{
   q(func: has(state)) {
      name
      state @facets {
         name
      }
   }
}

Result:

{
  "data": {
    "q": [
      {
        "name": "Francesc",
        "speaks": [
          {
            "name": "Spanish"
          },
          {
            "name": "Chinese"
          }
        ],
        "speaks|fluent": {
           "0": true,
           "1": false
        }
      }
    ]
  }
}

[MichelDiz]

The old way of doing facets between edges still works. So there are no changes to it. Just in the List Type.

For list-type facets I think it is pretty okay to be like this:

I will document this.

{
   q(func: has(nickname)) @filter(eq(name,"Julian")) {
      nickname @facets
   }
}

Result:

{
    "q": [
      {
        "nickname|kind": {
          "0": "first",
          "1": "official",
          "2": "CS-GO"
        },
        "nickname": [
          "Jay-Jay",
          "Jules",
          "JB"
        ]
      }
    ]
  }

The JSON mutation executed

{
  "set": [
    {
      "uid": "_:Julian",
      "name": "Julian",
      "nickname|kind": "first",
      "nickname": "Jay-Jay"
    },
    {
      "uid": "_:Julian",
      "nickname|kind": "official",
      "nickname": "Jules"
    },
    {
      "uid": "_:Julian",
      "nickname|kind": "CS-GO",
      "nickname": "JB"
    }
  ]
}

In RDF

{
  set {
    _:Blank <nickname> "Cesc" (kind="friends") .
    _:Blank <nickname> "Francesc" (kind="official") .
    _:Blank <nickname> "Tete" .
  }
}

[MichelDiz]

Docs added, waiting for review. #4582

[emile-tawfik]

I haven't thought about reusing the same blanknode multiple times.

Concerning the benefits of the JSON mutation format in the docs (Source: https://docs.dgraph.io/mutations/#json-mutation-format)

It also eliminates the need for apps to have custom serialisation code

This is not true because, at least for edge value lists, the serialization/deserialization format aren't the same.

[hackintoshrao]

Hey @emile-tawfik ,

Thanks for reporting this issue, only an avid Dgraph user could notice such tricky inconsistencies :)
Yes, I agree that least for edge value lists, the serialization/deserialization format aren't the same., this is an issue for sure, we'll take this up further and propose a solution.

[ashish-goswami]

Hi all, we have discussed facets format internally and prepared one document with different possible formats. Please checks below discuss post and provide your feedback.
https://discuss.dgraph.io/t/facets-format-in-mutation-requests-and-query-responses/6416

[lgalatin]

Fixed in #5424