Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/slash: opt(GraphQL): filter existence queries on GraphQL side instead of using @filter(type) (#7757) #7760

Merged
merged 1 commit into from Apr 28, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Apr 28, 2021

For the existence queries we used to do:
query {\n Cuisine_1(func: eq(Cuisine.name, "yaMqnmHeov")) @filter(type(Cuisine)) {\n uid \n } \n}

The filter operation can be very heavy on dgraph.type as it may store millions of nodes. A better query could be like this:
query {\n Cuisine_1(func: eq(Cuisine.name, "yaMqnmHeov")) {\n uid dgraph.type \n } \n}

This PR removes the above @filter operation from the existence query and uses the suggested alternate query which is lightweight.
The existence check operation is path critical and this fix is expected to add some performance improvement along with preventing OOM.

(cherry picked from commit 690fbbe)


This change is Reviewable

@filter(type) (#7757)

For the existence queries we used to do:
 query {\n  Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) @filter(type(Cuisine)) {\n uid \n  } \n}

The filter operation can be very heavy on dgraph.type as it may store millions of nodes. A better query could be like this:
 query {\n  Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) {\n uid dgraph.type \n  } \n}

This PR removes the above @filter operation from the existence query and uses the suggested alternate query which is lightweight.
The existence check operation is path critical and this fix is expected to add some performance improvement along with preventing OOM.

(cherry picked from commit 690fbbe)
@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Apr 28, 2021
Copy link
Contributor

@vmrajas vmrajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NamanJain8 NamanJain8 merged commit bfc75c3 into release/v21.03-slash Apr 28, 2021
@NamanJain8 NamanJain8 deleted the naman/cp/gql-filter branch April 28, 2021 14:48
ahsanbarkati pushed a commit that referenced this pull request May 27, 2021
@filter(type) (#7757) (#7760)

For the existence queries we used to do:
 query {\n  Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) @filter(type(Cuisine)) {\n uid \n  } \n}

The filter operation can be very heavy on dgraph.type as it may store millions of nodes. A better query could be like this:
 query {\n  Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) {\n uid dgraph.type \n  } \n}

This PR removes the above @filter operation from the existence query and uses the suggested alternate query which is lightweight.
The existence check operation is path critical and this fix is expected to add some performance improvement along with preventing OOM.

(cherry picked from commit 690fbbe)
(cherry picked from commit bfc75c3)
ahsanbarkati pushed a commit that referenced this pull request May 27, 2021
@filter(type) (#7757) (#7760)

For the existence queries we used to do:
 query {\n  Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) @filter(type(Cuisine)) {\n uid \n  } \n}

The filter operation can be very heavy on dgraph.type as it may store millions of nodes. A better query could be like this:
 query {\n  Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) {\n uid dgraph.type \n  } \n}

This PR removes the above @filter operation from the existence query and uses the suggested alternate query which is lightweight.
The existence check operation is path critical and this fix is expected to add some performance improvement along with preventing OOM.

(cherry picked from commit 690fbbe)
(cherry picked from commit bfc75c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants