Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the Dgraph version when running live or bulk loader. #2736

Merged
merged 2 commits into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@danielmai
Copy link
Member

danielmai commented Nov 8, 2018

Related to e2783d6.

Would be useful to know when users are sharing their logs from the live or bulk loader.


This change is Reviewable

Show resolved Hide resolved dgraph/cmd/bulk/run.go Outdated
@manishrjain
Copy link
Member

manishrjain left a comment

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @danielmai)


dgraph/cmd/bulk/run.go, line 73 at r1 (raw file):

Previously, danielmai (Daniel Mai) wrote…

Isn't the version all the same across all the subcommands, though?

Yes. But, they could have been running an older version of Dgraph zero on their server and upgraded the binary on their desktop.

@danielmai
Copy link
Member Author

danielmai left a comment

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @manishrjain)


dgraph/cmd/bulk/run.go, line 73 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Yes. But, they could have been running an older version of Dgraph zero on their server and upgraded the binary on their desktop.

Done.

@manishrjain manishrjain merged commit a147571 into master Nov 16, 2018

4 of 5 checks passed

code-review/reviewable 2 files, 1 discussion left (manishrjain)
Details
CI (dgraph) TeamCity build finished
Details
GolangCI No issues found!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@manishrjain manishrjain deleted the danielmai/print_version_live_bulk branch Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.