New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug retrieving reverse edges of non-list uid predicates. #3005

Merged
merged 4 commits into from Feb 13, 2019

Conversation

Projects
None yet
3 participants
@martinmr
Copy link
Contributor

martinmr commented Feb 12, 2019

Reverse edges of a non-list uid predicate were not being treated as a
list, causing parts of the results to be dropped and have a weird
format.

This change fixes the bug and adds a couple of regression tests.


This change is Reviewable

Fix bug retrieving reverse edges of non-list uid predicates.
Reverse edges of a non-list uid predicate were not being treated as a
list, causing parts of the results to be dropped and have a weird
format.

This change fixes the bug and adds a couple of regression tests.

@martinmr martinmr requested a review from dgraph-io/team Feb 12, 2019

@codexnull
Copy link
Contributor

codexnull left a comment

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@martinmr martinmr requested a review from manishrjain Feb 13, 2019

@manishrjain
Copy link
Member

manishrjain left a comment

:lgtm:

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@martinmr martinmr merged commit 790524c into master Feb 13, 2019

5 checks passed

CI (dgraph) TeamCity build finished
Details
GolangCI No issues found!
Details
code-review/reviewable 3 files reviewed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@martinmr martinmr deleted the martinmr/fix-reverse-bug branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment