Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update live loader flag help text. #3278

Merged
merged 2 commits into from Apr 10, 2019

Conversation

@danielmai
Copy link
Member

commented Apr 10, 2019

The live loader can already take in multiple Dgraph Alpha addresses to
distribute the load across the cluster during loading. The flag help text makes
this option clearer.


This change is Reviewable

The live loader can already take in multiple Dgraph Alpha addresses to
distribute the load across the cluster during loading. The flag help text makes
this option clear.
@danielmai danielmai requested a review from dgraph-io/team Apr 10, 2019
@@ -87,7 +87,7 @@ func init() {
flag.StringP("files", "f", "", "Location of *.rdf(.gz) or *.json(.gz) file(s) to load")
flag.StringP("schema", "s", "", "Location of schema file")
flag.String("format", "", "Specify file format (rdf or json) instead of getting it from filename")
flag.StringP("dgraph", "d", "127.0.0.1:9080", "Dgraph alpha gRPC server address")
flag.StringP("dgraph", "d", "127.0.0.1:9080", "Comma-separated list of Dgraph alpha gRPC server addresses")

This comment has been minimized.

Copy link
@golangcibot

golangcibot Apr 10, 2019

line is 108 characters (from lll)

Copy link
Contributor

left a comment

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai)

@danielmai danielmai requested a review from manishrjain Apr 10, 2019
Copy link
Member

left a comment

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai)

@danielmai danielmai merged commit da84554 into master Apr 10, 2019
4 of 5 checks passed
4 of 5 checks passed
code-review/reviewable 1 discussion left (danielmai)
Details
Blockade (dgraph) TeamCity build finished
Details
CI (dgraph) TeamCity build finished
Details
GolangCI No issues found!
Details
license/cla Contributor License Agreement is signed.
Details
@danielmai danielmai deleted the danielmai/live-flag branch Apr 10, 2019
MichelDiz added a commit that referenced this pull request Apr 12, 2019
Added about distributed load related to #3278
Change in increment section is related to #3284
MichelDiz added a commit that referenced this pull request Apr 12, 2019
* Docs: Distributed Load and change increment flag

Added about distributed load related to #3278
Change in increment section is related to #3284

* docs: Update description for live loader's alpha flag.
dna2github added a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
The live loader can already take in multiple Dgraph Alpha addresses to
distribute the load across the cluster during loading. The flag help text makes
this option clear.
dna2github added a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
* Docs: Distributed Load and change increment flag

Added about distributed load related to dgraph-io#3278
Change in increment section is related to dgraph-io#3284

* docs: Update description for live loader's alpha flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.