Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor: avoid double parsing of mutation string in ACL #3494
manishrjain left a comment
I don't get this refactoring. It changes the sequence of mutation handling quite significantly. For e.g., we check for context, then check if the request is empty, only then we try to parse the mutation. This change reorders all of that.
What's the rationale?
mangalaman93 left a comment
I modified this sequence to -