Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run bulk loader existence check on individual files #3681

Merged
merged 1 commit into from Jul 17, 2019

Conversation

gitlw
Copy link

@gitlw gitlw commented Jul 17, 2019

When multiple files are provided to the bulk loader, e.g. dgraph bulk -f a.rdf.gz,b.rdf.gz
we should check whether each individual file exists, instead of checking existence for the whole argument "a.rdf.gz,b.rdf.gz"


This change is Reviewable

…e validation should be run on

individual files
@gitlw gitlw requested review from manishrjain and a team as code owners July 17, 2019 21:25
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@gitlw gitlw merged commit f1c5f44 into master Jul 17, 2019
@gitlw gitlw deleted the gitlw/bl_multiple_files branch July 17, 2019 22:22
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants