Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ristretto/z in vendor #3750 #3751

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@prashant-shahi
Copy link
Member

commented Aug 5, 2019

Added ristretto/z using govendor.

Resolve of the issue seen in #3750

This change is Reviewable

@prashant-shahi prashant-shahi requested review from manishrjain and dgraph-io/team as code owners Aug 5, 2019

@CLAassistant

This comment has been minimized.

Copy link

commented Aug 5, 2019

CLA assistant check
All committers have signed the CLA.

@mangalaman93
Copy link
Contributor

left a comment

@prashant-shahi The code for the package is missing.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain)

@danielmai danielmai changed the title Adding restretto/z in vendor #3750 Adding ristretto/z in vendor #3750 Aug 5, 2019

@prashant-shahi
Copy link
Member Author

left a comment

@mangalaman93 Done

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @manishrjain)

@prashant-shahi prashant-shahi requested a review from mangalaman93 Aug 6, 2019

@pullrequest
Copy link

left a comment

A review job has been created and sent to the PullRequest network.


@prashant-shahi you can click here to see the review status or cancel the code review job.

@pullrequest
Copy link

left a comment

1 Message
⚠️ Due to its size, this pull request will likely have a little longer turnaround time and will probably require multiple passes from our reviewers.

@danielmai
Copy link
Member

left a comment

:lgtm:

Reviewed 1 of 1 files at r1, 7 of 7 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@prashant-shahi prashant-shahi merged commit 2883f66 into master Aug 8, 2019

5 checks passed

Blockade (dgraph) TeamCity build finished
Details
CI (dgraph) TeamCity build finished
Details
GolangCI No issues found!
Details
code-review/reviewable 8 files reviewed (manishrjain)
Details
license/cla Contributor License Agreement is signed.
Details

@prashant-shahi prashant-shahi deleted the prashant/vendor-add-ristretto/z branch Aug 9, 2019

danielmai added a commit that referenced this pull request Aug 9, 2019

Adding ristretto/z in vendor #3750 (#3751)
* Adding restretto/z in vendor

* Adding code for restretto

(cherry picked from commit 2883f66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.