Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs site: moved master to below latest #3933

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@prashant-shahi
Copy link
Member

commented Sep 6, 2019

This change is Reviewable

@pullrequest
Copy link

left a comment

A review job has been created and sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

@pullrequest
Copy link

left a comment

1 Message
The description of this pull request is blank. Adding a high-level summary will help our reviewers provide better feedback.

@prashant-shahi prashant-shahi requested a review from mangalaman93 Sep 6, 2019

@pullrequest
Copy link

left a comment

LGTM. Not much to say about a 2-line diff but a couple suggestions to consider to make future changes easier and safer.


Reviewed with ❤️ by PullRequest

wiki/scripts/build.sh Show resolved Hide resolved
@martinmr
Copy link
Member

left a comment

:lgtm: other than the suggestions by reviewable.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai, @mangalaman93, @MichaelJCompton, and @prashant-shahi)

@prashant-shahi prashant-shahi merged commit c19843b into master Sep 9, 2019

4 of 5 checks passed

code-review/reviewable 1 file, 1 discussion left (danielmai, martinmr, MichaelJCompton, pullrequest[bot])
Details
Blockade (dgraph) TeamCity build finished
Details
CI (dgraph) TeamCity build finished
Details
GolangCI No issues found!
Details
license/cla Contributor License Agreement is signed.
Details

@prashant-shahi prashant-shahi deleted the prashant/version-reorder branch Sep 9, 2019

danielmai added a commit that referenced this pull request Sep 10, 2019
Docs site: moved master to below latest (#3933)
* Docs site: moved master to below latest(v1.1.0)

* Updating comments in build.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.