Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran local and build scripts through shellcheck.net #3948

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@prashant-shahi
Copy link
Member

commented Sep 9, 2019

Ran local and build scripts through shellcheck.


This change is Reviewable

@pullrequest
Copy link

left a comment

A review job has been created and sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

@martinmr
Copy link
Member

left a comment

:lgtm:

One thing, is there a way to sort of automate this? I was thinking a small script that finds all the shell scripts in the repo (excluding the vendor directory) and formats them with shellcheck. No need to block the PR on this.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @danielmai and @MichaelJCompton)

@danielmai
Copy link
Member

left a comment

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @danielmai and @MichaelJCompton)

@pullrequest
Copy link

left a comment

It's a good practice to run scripts/code through linters -- good job!


Reviewed with ❤️ by PullRequest

@prashant-shahi prashant-shahi merged commit b6f25fe into master Sep 10, 2019

4 of 5 checks passed

code-review/reviewable 2 files left (MichaelJCompton)
Details
Blockade (dgraph) TeamCity build finished
Details
CI (dgraph) TeamCity build finished
Details
GolangCI No issues found!
Details
license/cla Contributor License Agreement is signed.
Details

@prashant-shahi prashant-shahi deleted the prashant/shellcheck branch Sep 10, 2019

danielmai added a commit that referenced this pull request Sep 13, 2019
Ran local and build scripts through shellcheck.net (#3948)
* Ran local and build scripts through shellcheck.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.