Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JSON upsert examples in docs #4104

Merged
merged 5 commits into from Oct 4, 2019

Conversation

@prashant-shahi
Copy link
Member

commented Sep 30, 2019

This change is Reviewable

Copy link

left a comment

A review job has been created and sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

Copy link

left a comment

1 Message
It looks like the description for this pull request is either blank or very short. Adding a high-level summary will help our reviewers provide better feedback. Feel free to include questions for PullRequest reviewers and make specific feedback requests.

Copy link

left a comment

There are three typos, which have suggested changes provided inline.


Reviewed with ❤️ by PullRequest

}
```

The result if the no user with the specified `email` was found :

This comment has been minimized.

Copy link
@pullrequest

pullrequest bot Sep 30, 2019

Minor typo: 'The result if no user with the specified email was found.'

This comment has been minimized.

Copy link
@prashant-shahi

prashant-shahi Oct 1, 2019

Author Member

Oh. Right!
My bad. will fix that.

}
```

The second example was to add the `age` information for the same user having the same email `user@company1.io`.

This comment has been minimized.

Copy link
@pullrequest

pullrequest bot Sep 30, 2019

Minor typo: 'The second example will add the age of the same user (user@company1.io)'

This comment has been minimized.

Copy link
@prashant-shahi

prashant-shahi Oct 1, 2019

Author Member

Since the same examples were previously done with rdf and now being re-done with json, I used was instead of will.


The second example was to add the `age` information for the same user having the same email `user@company1.io`.

We can achieve it using the following:

This comment has been minimized.

Copy link
@pullrequest

pullrequest bot Sep 30, 2019

We add the age for user1 using the following curl request:

This comment has been minimized.

Copy link
@prashant-shahi

prashant-shahi Oct 1, 2019

Author Member

Sure, I will make the changes.

wiki/content/mutations/index.md Outdated Show resolved Hide resolved
wiki/content/mutations/index.md Outdated Show resolved Hide resolved
@prashant-shahi prashant-shahi requested a review from mangalaman93 Oct 3, 2019
Copy link
Contributor

left a comment

Reviewable status: 0 of 1 files reviewed, 7 unresolved discussions (waiting on @danielmai, @mangalaman93, @MichaelJCompton, @prashant-shahi, and @pullrequest[bot])


wiki/content/mutations/index.md, line 929 at r3 (raw file):

You can achieved the same result with json using the following:

We can achieve the same result using json dataset as follows:

And we should probably move it below because the explanation below is for RDF.


wiki/content/mutations/index.md, line 996 at r3 (raw file):

You can achieved the same result with json using the following:

same here

@mangalaman93 mangalaman93 self-requested a review Oct 3, 2019
Copy link
Member Author

left a comment

Reviewable status: 0 of 1 files reviewed, 5 unresolved discussions (waiting on @danielmai, @mangalaman93, @MichaelJCompton, @prashant-shahi, and @pullrequest[bot])


wiki/content/mutations/index.md, line 929 at r3 (raw file):

Previously, mangalaman93 (Aman Mangal) wrote…

We can achieve the same result using json dataset as follows:

And we should probably move it below because the explanation below is for RDF.

Done.


wiki/content/mutations/index.md, line 996 at r3 (raw file):

Previously, mangalaman93 (Aman Mangal) wrote…

same here

Done.

Copy link
Contributor

left a comment

This looks good to me. We need to add an example for Conditional Upsert as well.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai, @mangalaman93, @MichaelJCompton, and @pullrequest[bot])

@mangalaman93 mangalaman93 self-requested a review Oct 3, 2019
Copy link
Contributor

left a comment

As long as the queries work :lgtm:

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai, @mangalaman93, @MichaelJCompton, and @pullrequest[bot])

@mangalaman93 mangalaman93 self-requested a review Oct 3, 2019
@prashant-shahi prashant-shahi merged commit bd70cba into master Oct 4, 2019
3 of 4 checks passed
3 of 4 checks passed
code-review/reviewable 1 file, 1 discussion left (danielmai, mangalaman93, MichaelJCompton, pullrequest[bot])
Details
CI (dgraph) TeamCity build finished
Details
GolangCI No issues found!
Details
license/cla Contributor License Agreement is signed.
Details
@prashant-shahi prashant-shahi deleted the prashant/json-upsert branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.