Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration .deepsource.toml #4106

Merged
merged 1 commit into from Sep 30, 2019
Merged

Add configuration .deepsource.toml #4106

merged 1 commit into from Sep 30, 2019

Conversation

dolftax
Copy link
Contributor

@dolftax dolftax commented Sep 30, 2019

This PR adds .deepsource.toml configuration file to run Continuous Quality analysis on the repo with DeepSource. Upon enabling DeepSource, quality analysis will be run on every PR to detect 120+ types of problems in the changes — including bug risks, anti-patterns, security vulnerabilities, etc.

Report from my latest fork: https://deepsource.io/gh/jaipradeesh/dgraph/issues/

To enable DeepSource analysis after merging this PR, please follow these steps:

  • Signup on DeepSource with your GitHub account and grant access to this repo.
  • Activate analysis on this repo here.

Docs: https://deepsource.io/docs/

@martinmr @manishrjain


This change is Reviewable

@dolftax dolftax requested review from manishrjain and a team as code owners September 30, 2019 18:12
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@jaipradeesh you can click here to see the review status or cancel the code review job.

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please seem comment regarding exclude_patters inline.


Reviewed with ❤️ by PullRequest

'**/*_test.go'
]

exclude_patterns = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the exclude_patterns code will not include any details, it should be removed. Future configuration can add it in when it actually being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants