Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating local script to support docs preview of PR #4512

Merged
merged 2 commits into from Jan 8, 2020

Conversation

@prashant-shahi
Copy link
Member

prashant-shahi commented Jan 7, 2020

Closed the previously raised PR for Netlify. Replacing it with surge.sh.

This change is Reviewable

Copy link
Member

animesh2049 left a comment

:lgtm_strong:

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @danielmai, @MichaelJCompton, and @prashant-shahi)


wiki/scripts/local.sh, line 46 at r1 (raw file):

  if [[ $1 == "-p" || $1 == "--preview" ]]; then
      echo -e "$(date) $GREEN  Generating documentation static pages in the public folder. $RESET"
      hugo \

Put the flags in the same line.


wiki/scripts/local.sh, line 50 at r1 (raw file):

      echo -e "$(date) $GREEN  Done building. $RESET"
  else
    CURRENT_VERSION=${CURRENT_VERSION} hugo server -w \

Same here

@prashant-shahi prashant-shahi requested a review from animesh2049 Jan 8, 2020
Copy link
Member Author

prashant-shahi left a comment

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @animesh2049, @danielmai, and @MichaelJCompton)


wiki/scripts/local.sh, line 46 at r1 (raw file):

Previously, animesh2049 (Animesh Chandra Pathak) wrote…

Put the flags in the same line.

Done.


wiki/scripts/local.sh, line 50 at r1 (raw file):

Previously, animesh2049 (Animesh Chandra Pathak) wrote…

Same here

Done.

@prashant-shahi prashant-shahi merged commit b0622ed into master Jan 8, 2020
7 of 8 checks passed
7 of 8 checks passed
code-review/reviewable 1 file, 2 discussions left (animesh2049, danielmai, MichaelJCompton)
Details
CI (dgraph) TeamCity build finished
Details
DeepSource: Go Analysis Passed: No blocking issues detected.
Details
Docs-Preview (dgraph) TeamCity build finished
Details
Docs-Preview/dgraph-0e9f3f6fd9-38199 Deployment ready!
Details
Docs-Preview/dgraph-0e9f3f6fd9-38206 Deployment ready!
Details
GolangCI No issues found!
Details
license/cla Contributor License Agreement is signed.
Details
@prashant-shahi prashant-shahi deleted the prashant/adding-preview-build branch Jan 8, 2020
danielmai added a commit that referenced this pull request Jan 12, 2020
* updating local script to support preview

(cherry picked from commit b0622ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.