Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating local build script #4519

Merged
merged 2 commits into from Jan 8, 2020
Merged

Conversation

@prashant-shahi
Copy link
Member

prashant-shahi commented Jan 8, 2020

  • changing SSH to HTTPS for git clone
  • indentation fixes

This change is Reviewable

@prashant-shahi

This comment has been minimized.

Copy link
Member Author

prashant-shahi commented Jan 8, 2020

These are minor changes so merging it now.
I will be making any required changes for the script later along with future changes.

@prashant-shahi prashant-shahi merged commit 433f70b into master Jan 8, 2020
6 checks passed
6 checks passed
CI (dgraph) TeamCity build finished
Details
DeepSource: Go Analysis Passed: No blocking issues detected.
Details
Docs-Preview (dgraph) TeamCity build finished
Details
Docs-Preview/dgraph-fad8af02f7-38243 Deployment ready!
Details
GolangCI No issues found!
Details
license/cla Contributor License Agreement is signed.
Details
@prashant-shahi prashant-shahi deleted the prashant/updating-local-script branch Jan 8, 2020
danielmai added a commit that referenced this pull request Jan 12, 2020
* changing ssh to https for git clone and indentation fixes

* removing the baseurl set in config.toml - considers the domain name as baseURL

(cherry picked from commit 433f70b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.