Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for zero leader connection. #4709

Merged
merged 2 commits into from Feb 11, 2020
Merged

Conversation

@danielmai
Copy link
Member

danielmai commented Jan 31, 2020

This error message is about a connection to the Zero leader, not just any Zero server. This PR clarifies the returned error message to state that.


This change is Reviewable

@danielmai danielmai requested review from manishrjain and dgraph-io/team as code owners Jan 31, 2020
Copy link
Member

martinmr left a comment

:lgtm:

Just one minor comment.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai and @manishrjain)


worker/groups.go, line 283 at r1 (raw file):

	p := g.Leader(0)
	if p == nil {
		return errors.Errorf("Don't have the address of any dgraph zero leader")

error messages should start with lowercase to follow golang's convention.

Copy link
Member

MichelDiz left a comment

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai and @manishrjain)

Copy link
Member

prashant-shahi left a comment

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai and @manishrjain)

@martinmr martinmr merged commit 79d27d3 into master Feb 11, 2020
5 of 6 checks passed
5 of 6 checks passed
code-review/reviewable 1 discussion left (danielmai, manishrjain)
Details
Blockade (dgraph) TeamCity build finished
Details
CI (dgraph) TeamCity build finished
Details
DeepSource: Go Analysis Passed: No blocking issues detected.
Details
GolangCI No issues found!
Details
license/cla Contributor License Agreement is signed.
Details
@martinmr martinmr deleted the danielmai/fix-error-message branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.