Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing docker-compose YAML file contents with links to config files #4723

Merged
merged 2 commits into from Feb 3, 2020

Conversation

@prashant-shahi
Copy link
Member

prashant-shahi commented Feb 3, 2020

Fixes #4623

  • Using links instead of copy/pasting the docker-compose file contents
  • other minor fixes

This change is Reviewable

Docs Preview: Dgraph Preview

- including other minor fixes

Signed-off-by: Prashant Shahi <coolboi567@gmail.com>
@prashant-shahi prashant-shahi requested review from danielmai and sleto-it Feb 3, 2020
@prashant-shahi prashant-shahi requested a review from MichaelJCompton as a code owner Feb 3, 2020
Copy link
Member

danielmai left a comment

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton and @sleto-it)

Signed-off-by: Prashant Shahi <coolboi567@gmail.com>
Copy link
Member

danielmai left a comment

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton and @sleto-it)

@prashant-shahi prashant-shahi merged commit ee8d780 into master Feb 3, 2020
7 checks passed
7 checks passed
CI (dgraph) TeamCity build finished
Details
DeepSource: Go Analysis Passed: No blocking issues detected.
Details
Docs-Preview (dgraph) TeamCity build finished
Details
Docs-Preview/dgraph-5e9879256d-42758 Deployment ready!
Details
GolangCI No issues found!
Details
code-review/reviewable 1 file reviewed (MichaelJCompton, sleto-it)
Details
license/cla Contributor License Agreement is signed.
Details
@prashant-shahi prashant-shahi deleted the prashant/replace-yml-with-link branch Feb 3, 2020
@sleto-it

This comment has been minimized.

Copy link
Member

sleto-it commented Feb 4, 2020

Thanks @prashant-shahi

prashant-shahi added a commit that referenced this pull request Feb 5, 2020
#4723)

- Replacing docker-compose yml files with links
- Adding more instructions and output logs
- Other minor fixes

Signed-off-by: Prashant Shahi <coolboi567@gmail.com>
(cherry picked from commit ee8d780)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.