Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdc): Show namespace info in event meta #7721

Merged
merged 3 commits into from Apr 14, 2021
Merged

fix(cdc): Show namespace info in event meta #7721

merged 3 commits into from Apr 14, 2021

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Apr 14, 2021 •
edited

This PR sets the namespace in the cdc event metadata.

I've also changed the type of key from []byte to uint64 because it didn't need to be a []byte

This change is Reviewable

@jarifibrahim jarifibrahim marked this pull request as ready for review April 14, 2021 13:53
@NamanJain8
Copy link
Contributor

NamanJain8 commented Apr 14, 2021 •
edited

Looks good. 🎉
Would this be a breaking change?

@jarifibrahim
Copy link
Contributor Author

Would this be a breaking change?

@NamanJain8 The JSON would have an additional field called namespace. It shouldn't be breaking.
See this https://play.golang.org/p/g4WEr-a5SSv . The "Age" in json wasn't part of the struct

@jarifibrahim jarifibrahim merged commit 06d7284 into master Apr 14, 2021
@jarifibrahim jarifibrahim deleted the ibrahim/cdc-ns branch April 14, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aman-bansal aman-bansal aman-bansal approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

@vvbalaji-dgraph vvbalaji-dgraph Awaiting requested review from vvbalaji-dgraph

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jarifibrahim @NamanJain8 @aman-bansal