Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump badger up to v4 #8709

Merged
merged 9 commits into from Mar 1, 2023
Merged

chore(deps): bump badger up to v4 #8709

merged 9 commits into from Mar 1, 2023

Conversation

joshua-goldstein
Copy link
Contributor

@joshua-goldstein joshua-goldstein commented Feb 28, 2023 •
edited

We bump up the dependency on Badger to v4. This requires regenerating protobuf files.

@github-actions github-actions bot added area/bulk-loader Issues related to bulk loading. area/core internal mechanisms area/enterprise Related to proprietary features area/enterprise/backup Related to binary backups area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/live-loader Issues related to live loading. area/schema Issues related to the schema language and capabilities. area/testing Testing related issues go Pull requests that update Go code labels Feb 28, 2023
@joshua-goldstein joshua-goldstein marked this pull request as ready for review February 28, 2023 03:16
@coveralls
Copy link

coveralls commented Feb 28, 2023 •
edited

Coverage Status

Coverage: 67.184% (+0.03%) from 67.155% when pulling d94794c on joshua/badger-dep into 6926adc on main.

@joshua-goldstein joshua-goldstein mentioned this pull request Feb 28, 2023
Closed
skrdgraph
skrdgraph approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshua-goldstein joshua-goldstein merged commit 61f2ea2 into main Mar 1, 2023
8 checks passed
@joshua-goldstein joshua-goldstein deleted the joshua/badger-dep branch March 1, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrdgraph skrdgraph skrdgraph approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@MichelDiz MichelDiz Awaiting requested review from MichelDiz

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/bulk-loader Issues related to bulk loading. area/core internal mechanisms area/enterprise/backup Related to binary backups area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/live-loader Issues related to live loading. area/schema Issues related to the schema language and capabilities. area/testing Testing related issues go Pull requests that update Go code v23.0.0-beta
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joshua-goldstein @coveralls @skrdgraph @mangalaman93