Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add ci to pydgraph #192

Merged
merged 23 commits into from Apr 25, 2023
Merged

chore(ci): add ci to pydgraph #192

merged 23 commits into from Apr 25, 2023

Conversation

joshua-goldstein
Copy link
Contributor

@joshua-goldstein joshua-goldstein commented Mar 26, 2023

See https://github.com/joshua-goldstein/pydgraph/actions/runs/4526909926/jobs/7972368806 for sample workflow.

Remarks

  • Protobuf requires <4.0.0, otherwise build fails. Minimum required is unclear.
  • gRPC works with 1.51; in different places, the minimum is 1.18 and 1.38
  • Readme says "To avoid issues when adding composite credentials or when using client authorization, please install gRPC version 1.19.0"
  • Tests run using Python 3.11.2. Dependency / build problems seem to arise because of protobuf and grpc libraries, not Python versions
  • I have removed tox while we get CI running. We can revisit this later. Before implementing tox, we should get code coverage working.

TODO (next PR)

  • We will need to update requirements.txt and possibly regenerate protobufs for next release

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2023

CLA assistant check
All committers have signed the CLA.

@joshua-goldstein
Copy link
Contributor Author

joshua-goldstein commented Mar 27, 2023

Minimal setup to run tests. Run pip install -r requirements.txt with

grpcio==1.51.3
protobuf==3.17.3

in the requirements file. To run tests, we also need pip install setuptools==67.6.0. Then run bash scripts/local-test.sh. This is on Python 3.11.2. Also note that Dgraph binary must be located in $GOPATH/bin for ACL tests to work.

examples/simple/docker-compose.yml Outdated Show resolved Hide resolved
Copy link

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skrdgraph skrdgraph merged commit d81466a into master Apr 25, 2023
4 checks passed
@skrdgraph skrdgraph deleted the joshua/py branch April 25, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants