fix: ratel editor freezing when typing #391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an infinite loop caused by mutual updates between the editor's onChange handler and the query prop.
Previously, onChange would trigger onUpdateQuery, which updated the query prop.
A useEffect would then detect the new query and update the editor value again which would then retrigger the onChange handler, creating a loop.
Added a stable
isSettingContentstatus ref to understand when the query is being updated and to return early from the onchange handler if it's active.Checklist
CHANGELOG.mdfile describing and linking tothis PR
staged and linked here